Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dpp and dfr render template on mobile UIs #183

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

huynguyen-hl
Copy link
Contributor

@huynguyen-hl huynguyen-hl commented Dec 12, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR aims to fix the DPP and DFR render templates to prevent horizontal scrolling on mobile screens smaller than 200px.

Related Tickets & Documents

https://github.com/gs-gs/fa-ag-trace/issues/801

Mobile & Desktop Screenshots/Recordings

The DPP render template:

image image image image

The DFR render template:

image image image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“– Mock App docs site
  • πŸ“œ README.md
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

Copy link

Code Coverage Report

Lines Statements Branches Functions
Coverage: 75%
74.69% (3102/4153) 56.17% (623/1109) 64.61% (336/520)
Title Lines Statements Branches Functions
All packages Coverage: 75%
74.69% (3102/4153) 56.17% (623/1109) 64.61% (336/520)
Components Coverage: 84%
84.03% (516/614) 69.36% (120/173) 77.23% (95/123)
Mock app Coverage: 71%
71.89% (371/516) 53.23% (74/139) 68.14% (77/113)
Services Coverage: 81%
79.08% (1025/1296) 64.15% (247/385) 76.08% (105/138)
UNTP test suite Coverage: 85%
85.74% (1083/1263) 81.03% (141/174) 67.21% (41/61)
VC test suite Coverage: 100%
100% (20/20) 100% (2/2) 100% (4/4)
UNTP Playground Coverage: 25%
25.1% (120/478) 17.22% (41/238) 21.17% (18/85)

@huynguyen-hl huynguyen-hl merged commit 5f8c113 into next Dec 16, 2024
2 checks passed
@huynguyen-hl huynguyen-hl deleted the fix/update-render-templates-mobile-ui branch December 16, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants